javeme commented on code in PR #342: URL: https://github.com/apache/incubator-hugegraph-doc/pull/342#discussion_r1545474762
########## dist/validate-release.sh: ########## @@ -153,15 +154,17 @@ for i in *src.tar.gz; do done # 4.8: test compile the packages - if [[ ($JAVA_VERSION == 8 && "$i" =~ "computer") ]] || [[ "$i" =~ 'hugegraph-ai' ]]; then - echo "Skip compile computer module in java8 & AI module in all versions" - popd - continue + if [[ ($JAVA_VERSION == 8 && "$i" =~ "hugegraph-computer") ]]; then + echo "Skip compile $i module in java8" + elif [[ "$i" =~ 'hugegraph-ai' ]]; then + echo "Skip compile $i module in all versions" + elif [[ "$i" =~ "hugegraph-commons" ]]; then + mvn install -DskipTests -Papache-release -ntp -e Review Comment: to avoid error when hugegraph-core compile: `Could not find artifact org.apache.hugegraph:hugegraph-common` ########## dist/validate-release.sh: ########## @@ -21,8 +21,8 @@ # 3. Compile the source package & run server & toolchain # 4. Run server & toolchain in binary package -# if we don't want to exit after '|', remove "-o pipefail" -set -exo pipefail +# exit when any error occurs +set -e Review Comment: remove `-o pipefail` because it will exit when `COUNT=$(grep -E "$CATEGORY_X" LICENSE NOTICE | wc -l)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
