javeme commented on code in PR #342: URL: https://github.com/apache/incubator-hugegraph-doc/pull/342#discussion_r1552807172
########## dist/validate-release.sh: ########## @@ -21,8 +21,8 @@ # 3. Compile the source package & run server & toolchain # 4. Run server & toolchain in binary package -# if we don't want to exit after '|', remove "-o pipefail" -set -exo pipefail +# exit when any error occurs +set -e Review Comment: Note the grep will exit 1 if not found, although we can change this grep behavior, we don't need to ensure grep exits 0, because we will check the final result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
