imbajin commented on code in PR #342:
URL:
https://github.com/apache/incubator-hugegraph-doc/pull/342#discussion_r1553300738
##########
dist/validate-release.sh:
##########
@@ -153,15 +154,17 @@ for i in *src.tar.gz; do
done
# 4.8: test compile the packages
- if [[ ($JAVA_VERSION == 8 && "$i" =~ "computer") ]] || [[ "$i" =~
'hugegraph-ai' ]]; then
- echo "Skip compile computer module in java8 & AI module in all versions"
- popd
- continue
+ if [[ ($JAVA_VERSION == 8 && "$i" =~ "hugegraph-computer") ]]; then
+ echo "Skip compile $i module in java8"
+ elif [[ "$i" =~ 'hugegraph-ai' ]]; then
+ echo "Skip compile $i module in all versions"
+ elif [[ "$i" =~ "hugegraph-commons" ]]; then
+ mvn install -DskipTests -Papache-release -ntp -e
Review Comment:
> Is there any way to resolve this issue when running locally? If no, we can
locally install hugegraph-commons first.
3 ways for it:
1. enable/active stage repo in `settings.xml` (maven settings)
<img width="706" alt="image"
src="https://github.com/apache/incubator-hugegraph-doc/assets/17706099/3e8d7a94-92a4-4df4-9e82-f5b2e7bef0bc";>
3. use `mvn -P stage` to active the stage repo profile
4. install common from the source code manually
My view: prefer `way 1 > way 3 > way 2`
And we should consider **merging** `commons` into `toolchain` or `hugegraph`
repo, instead of use `stage` everywhere
Actually, it's almost rarely to see any ASF projects released/accessed like
this:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
