imbajin commented on code in PR #2952:
URL:
https://github.com/apache/incubator-hugegraph/pull/2952#discussion_r2837673792
##########
docker/docker-compose.yml:
##########
@@ -15,44 +15,98 @@
# limitations under the License.
#
-version: "3"
+name: hugegraph-single
+
+networks:
+ hg-net:
+ driver: bridge
+
Review Comment:
⚠️ **`build:` context forces local source build — users should pull
published images by default**
Adding `build:` alongside `image:` means `docker compose up` will build
images from source rather than pulling the published `hugegraph/pd:1.7.0` from
Docker Hub. This:
1. Requires the full source tree to be present (unexpected for users who
just download the compose file)
2. Makes startup much slower (building 3 Java services)
3. May produce a different image than the official release
The compose file in `docker/` is intended as a quickstart. The `build:`
blocks are appropriate in a separate `docker-compose.dev.yml` or similar, not
the main file.
```suggestion
pd:
image: hugegraph/pd:${HUGEGRAPH_VERSION:-1.7.0}
container_name: hg-pd
hostname: pd
```
If local builds are needed for development, consider a separate
`docker-compose.build.yml` override file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
