imbajin commented on code in PR #2952: URL: https://github.com/apache/incubator-hugegraph/pull/2952#discussion_r2837738649
########## hugegraph-server/hugegraph-dist/docker/scripts/detect-storage.groovy: ########## @@ -1,26 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -import org.apache.hugegraph.HugeFactory -import org.apache.hugegraph.dist.RegisterUtil - -// register all the backend to avoid changes if needs to support other backend -RegisterUtil.registerPlugins() -RegisterUtil.registerRocksDB() -RegisterUtil.registerHBase() - -graph = HugeFactory.open('./conf/graphs/hugegraph.properties') Review Comment: ‼️ **Critical: deleting this script while related Docker references remain can break build workflows** This file is removed in this PR, but the server Docker build flow still references `detect-storage.groovy` in current Dockerfiles. That creates an inconsistency and can fail local build paths when Compose/build expects the file. Please align this PR by either: 1. removing stale `COPY ... detect-storage.groovy` references from server Dockerfiles, or 2. keeping a temporary compatibility stub until those references are removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
