imbajin commented on code in PR #2952:
URL:
https://github.com/apache/incubator-hugegraph/pull/2952#discussion_r2837741333
##########
docker/docker-compose.yml:
##########
@@ -15,44 +15,98 @@
# limitations under the License.
#
-version: "3"
+name: hugegraph-single
+
+networks:
+ hg-net:
+ driver: bridge
+
+volumes:
+ hg-pd-data:
+ hg-store-data:
services:
pd:
- image: hugegraph/pd
- container_name: pd
+ build:
+ context: ..
+ dockerfile: hugegraph-pd/Dockerfile
+ image: hugegraph/pd:${HUGEGRAPH_VERSION:-1.7.0}
Review Comment:
⚠️ **Important: quickstart default tag may cause pull failures or unexpected
local builds**
This compose file defaults to `${HUGEGRAPH_VERSION:-1.7.0}`. If that tag is
unavailable in registry, quickstart users can hit pull failures (or unexpected
local builds when `build:` is present).
For a quickstart-oriented file, prefer a reliably available default tag and
let users override explicitly.
```suggestion
image: hugegraph/pd:${HUGEGRAPH_VERSION:-latest}
```
Please keep PD/Store/Server default tag policy aligned to avoid
mixed-version startup behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
