imbajin commented on code in PR #2952:
URL:
https://github.com/apache/incubator-hugegraph/pull/2952#discussion_r2837673792
##########
docker/docker-compose.yml:
##########
@@ -15,44 +15,98 @@
# limitations under the License.
#
-version: "3"
+name: hugegraph-single
+
+networks:
+ hg-net:
+ driver: bridge
+
Review Comment:
⚠️ **`build:` in quickstart compose can unexpectedly trigger local source
builds — prefer pull-only defaults**
Using `build:` together with `image:` does **not** always force a local
build. In Compose, the usual behavior (depending on `pull_policy`) is to try
pulling first, then fall back to building if pull is unavailable.
That said, this is still risky for a quickstart file:
1. If the image/tag cannot be pulled, users unexpectedly need the full
source tree and Docker build context.
2. Startup becomes much slower because services may be built locally.
3. Locally built images can differ from official release artifacts, reducing
reproducibility.
Since `docker/docker-compose.yml` is intended for quickstart usage, I
recommend keeping it pull-only by default and moving `build:` blocks to a
dev-specific override (for example, `docker-compose.dev.yml`).
```suggestion
pd:
image: hugegraph/pd:${HUGEGRAPH_VERSION:-1.7.0}
container_name: hg-pd
hostname: pd
```
If local builds are needed for development, users can combine files
explicitly, e.g.:
`docker compose -f docker/docker-compose.yml -f
docker/docker-compose.dev.yml up`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
