Muawiya-contact commented on issue #326:
URL: https://github.com/apache/hugegraph-ai/issues/326#issuecomment-4409325198
<html>
<body>
<!--StartFragment--><html><head></head><body><h1>Implementation Plan —
#326</h1>
<h2>Goal</h2>
<p>Replace the no-op guard in <code>test_metric.py</code> with a
deterministic assertion so shape drift in <code>backend_metrics</code> surfaces
as a <strong>failure</strong>, not a silent pass.</p>
<hr>
<h2>Steps</h2>
<ol>
<li><strong>Run</strong> <code>test_metrics_operations</code> against
HugeGraph 1.7.0 and print the raw <code>backend_metrics</code> response to
capture the actual shape</li>
<li><strong>Pin</strong> that shape as a constant — e.g.
<code>EXPECTED_SHAPE_1_7_0 = { ... }</code></li>
<li><strong>Replace</strong> the <code>if "hugegraph" in
backend_metrics:</code> guard with a hard assertion:
<pre><code class="language-python">assert "hugegraph" in backend_metrics, (
f"Expected 'hugegraph' key, got: {list(backend_metrics.keys())}")assert
backend_metrics["hugegraph"] == EXPECTED_SHAPE_1_7_0
</code></pre></li>
<li><strong>Version-gate</strong> if needed — add a branch for other known
server versions with their own pinned shapes</li>
<li><strong>Run</strong> the test suite to confirm it passes on 1.7.0 and
fails on a deliberately broken shape</li>
<li><strong>Open PR</strong> referencing #326, #325, #320</li>
</ol>
<hr>
<h2>Scope</h2>
Item | Detail
-- | --
File | hugegraph-python-client/src/tests/test_metric.py
Lines | L78–79 (test_metrics_operations)
Server | HugeGraph 1.7.0
Labels | test python-client
</body></html><!--EndFragment-->
</body>
</html>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
