Muawiya-contact commented on issue #326:
URL: https://github.com/apache/hugegraph-ai/issues/326#issuecomment-4430813897
Thanks @dosu for checking — I've now had this independently verified
by GitHub Copilot against the current main branch. Here's what it confirmed:
1. **Guard is present** — `if "hugegraph" in backend_metrics:` exists and
is flagged as a backward-compatibility workaround
2. **Assertion at L72–73** — only checks `len > 1`, no structural validation
3. **No shape validation** — the only checks are:
- `assertIsInstance(backend_metrics, dict)` — type only
- `assertTrue(backend_metrics)` — existence only
- The conditional guard itself
Shape drift inside `backend_metrics["hugegraph"]` would pass silently.
My original fix stands — pinning the actual 1.7.0 response shape and
replacing the guard with a deterministic structural assertion.
Happy to proceed with the fix as described above. Please assign. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
