Muawiya-contact commented on issue #326:
URL: https://github.com/apache/hugegraph-ai/issues/326#issuecomment-4467129555
Hey @imbajin 👋
Just a quick follow-up on **#326** — the discussion has settled
into a clean plan thanks to @dosu's help:
- The original guard concern turned out to be a non-issue on `main`
- But the **real gap remains**: `assertGreater(len(...), 1)` only
checks length, not structure — shape drift would still pass silently
**Proposed path forward:**
Fold the structural assertion fix into **#319**, where I'll capture
the actual `1.7.0` `backend_metrics` shape during the CI upgrade
and pin a deterministic assertion against it in the same PR.
Two quick questions when you get a moment:
1. Does that approach work for you, or would you prefer a separate PR?
2. Should I keep **#326** open as a reference (auto-closed via
`Resolves #326` in the #319 PR), or close it now?
No rush at all — just want to make sure I'm moving in the
right direction before I dig in. 🙏
— Muawiya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
