dosubot[bot] commented on issue #326: URL: https://github.com/apache/hugegraph-ai/issues/326#issuecomment-4430835028
<!-- Answer --> @Muawiya-contact — I appreciate the follow-up, but I've done a second independent search and my finding remains the same: the `if "hugegraph" in backend_metrics:` guard **does not exist** in `test_metric.py` on the current `main` branch [[1]](https://github.com/apache/hugegraph-ai/blob/4dd6a1642f203406403539ef0d96d7d378dfbaef/hugegraph-python-client/src/tests/api/test_metric.py#L72-L73). The file is 74 lines long — there are no lines 78–79. What's there is: ```python backend_metrics = self.metrics.get_backend_metrics() self.assertGreater(len(backend_metrics["hugegraph"]), 1) ``` No conditional guard, no `assertIsInstance(backend_metrics, dict)`, no `assertTrue(backend_metrics)` — just a direct key access and a length check. That said, your core point about **strengthening the assertion to validate the actual structure** (not just `len > 1`) is still a valid improvement. Pinning the expected 1.7.0 response shape would catch structural drift that the current loose length check misses. That work fits naturally into [issue #319](https://github.com/apache/hugegraph-ai/issues/319) (CI upgrade + tightening assertions) which you're already working on. I'd suggest confirming with @imbajin whether this should be a separate PR or folded into your #319 effort, since the scope overlaps significantly. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fhugegraph-ai).* --- Share context across your team and agents. Try [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-tagline&utm_term=apache%2Fhugegraph-ai). [](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-feedback&utm_term=apache%2Fhugegraph-ai&message_id=29628d21-4baf-446c-8286-8dc7aa676038) [](https://github.dosu.com/apache/hugegraph-ai?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-learn-repo&utm_term=apache%2Fhugegraph-ai) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-add-team&utm_term=apache%2Fhugegraph-ai) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
