imbajin commented on code in PR #504: URL: https://github.com/apache/hugegraph-doc/pull/504#discussion_r4148498967
########## content/en/docs/clients/restful-api/propertykey.md: ########## @@ -10,7 +10,7 @@ description: "PropertyKey REST API: Define data types and cardinality constraint Params Description: - name: The name of the property type, required. -- data_type: The data type of the property type, including: bool, byte, int, long, float, double, text, blob, date, uuid. The default data type is `text` (Represent a `string` type) +- data_type: The data type of the property type, including: bool, byte, int, long, float, double, decimal, text, blob, date, uuid. The default data type is `text` (Represent a `string` type). `decimal` holds an exact decimal number (Java `BigDecimal`): at most 128 significant digits and a scale of at most 128 in either direction; it is sent and returned as a plain JSON number with every digit, so a client must not parse it as a double Review Comment: ⚠️ Important. This says DECIMAL requests and responses both use JSON numbers, but paired server PR #3209 at head 0bb7724a406d9ee49ab5bfee719aa440ee6ab002 serializes REST BigDecimal responses as JSON strings. Please distinguish accepted exact JSON number/string inputs from string responses, and update the parallel Chinese paragraph too. Evidence: server JsonUtil registers BigDecimalSerializer, whose serialize() calls writeString(); JsonUtilTest.testSerializeBigDecimal() asserts quoted output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
