SebastianGruza commented on code in PR #504: URL: https://github.com/apache/hugegraph-doc/pull/504#discussion_r4165457447
########## content/en/docs/clients/hugegraph-client.md: ########## @@ -119,6 +119,7 @@ The constraint information that PropertyKey allows to define includes: name, dat | asByte() | Byte | | asBlob() | Byte[] | | asDouble() | Double | +| asDecimal() | BigDecimal | Review Comment: Agreed, this PR waits for the merge of apache/hugegraph#3209 and apache/hugegraph-toolchain#771. Both pages (en/cn) now carry a release note: the DECIMAL type ships with those PRs, and until they are merged sending `"data_type": "DECIMAL"` or calling `asDecimal()` fails. Marking the PR as on hold; I will lift it after the merges. ########## content/en/docs/clients/restful-api/propertykey.md: ########## @@ -10,7 +10,7 @@ description: "PropertyKey REST API: Define data types and cardinality constraint Params Description: - name: The name of the property type, required. -- data_type: The data type of the property type, including: bool, byte, int, long, float, double, text, blob, date, uuid. The default data type is `text` (Represent a `string` type) +- data_type: The data type of the property type, including: bool, byte, int, long, float, double, decimal, text, blob, date, uuid. The default data type is `text` (Represent a `string` type). `decimal` holds an exact decimal number (Java `BigDecimal`): at most 128 significant digits and a scale of at most 128 in either direction; in a request it may be sent as a JSON number or as a string and is read exactly either way; in a response it is returned as a string (e.g. `"amount": "12345678901234567890.123456789012345678"`), so a client parses it with `new BigDecimal(String)`, never as a double Review Comment: Done: one sentence on the limits in `propertykey.md` (en/cn) and next to the writeType table in `hugegraph-client.md`: a DECIMAL key cannot be an index field, a primary key or a sort key, and the only allowed write type is OLAP_COMMON. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
