bitflicker64 commented on code in PR #504: URL: https://github.com/apache/hugegraph-doc/pull/504#discussion_r4175879067
########## content/en/docs/clients/hugegraph-client.md: ########## @@ -119,6 +119,7 @@ The constraint information that PropertyKey allows to define includes: name, dat | asByte() | Byte | | asBlob() | Byte[] | | asDouble() | Double | +| asDecimal() | BigDecimal (exact decimal, not indexable, not a primary/sort key; from the release with apache/hugegraph#3209 and #771) | Review Comment: Minor: The reply on the earlier limits thread says the write type limit was added next to the writeType table here, but at 2c8bcbe this page only changes this row, and the row lists "not indexable, not a primary/sort key" without the write type. On apache/hugegraph#3209 at 2034d240, PropertyKeyBuilder.checkOlap() throws NotAllowException for a decimal key with OLAP_SECONDARY or OLAP_RANGE, so `asDecimal().writeType(WriteType.OLAP_RANGE)` fails at create time and this page does not warn about it. Please add the limit to this row or under the writeType table (for example: a decimal key allows only OLTP or OLAP_COMMON), and make the same change in content/cn/docs/clients/hugegraph-client.md line 123. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
