imbajin commented on code in PR #504: URL: https://github.com/apache/hugegraph-doc/pull/504#discussion_r4175644863
########## content/en/docs/clients/hugegraph-client.md: ########## @@ -119,6 +119,7 @@ The constraint information that PropertyKey allows to define includes: name, dat | asByte() | Byte | | asBlob() | Byte[] | | asDouble() | Double | +| asDecimal() | BigDecimal (exact decimal, not indexable, not a primary/sort key; from the release with apache/hugegraph#3209 and #771) | Review Comment: 🧹 Minor. Blocking: no. Summary: Please qualify #771 as apache/hugegraph-toolchain#771 in this row and the Chinese counterpart. Evidence: This row also names apache/hugegraph#3209, but an unqualified #771 resolves within apache/hugegraph-doc; the asDecimal() builder API is introduced by apache/hugegraph-toolchain#771. ########## content/en/docs/clients/restful-api/propertykey.md: ########## @@ -10,7 +10,7 @@ description: "PropertyKey REST API: Define data types and cardinality constraint Params Description: - name: The name of the property type, required. -- data_type: The data type of the property type, including: bool, byte, int, long, float, double, text, blob, date, uuid. The default data type is `text` (Represent a `string` type) +- data_type: The data type of the property type, including: bool, byte, int, long, float, double, decimal, text, blob, date, uuid. The default data type is `text` (Represent a `string` type). `decimal` holds an exact decimal number (Java `BigDecimal`): at most 128 significant digits and a scale of at most 128 in either direction; in a request it may be sent as a JSON number or as a string and is read exactly either way; in a response it is returned as a string (e.g. `"amount": "12345678901234567890.123456789012345678"`), so a client parses it with `new BigDecimal(String)`, never as a double. A decimal key cannot be indexed, used as a primary key or an edge sort key, or given an OLAP index write type (only `OLAP_COMMON`). Available from the release that ships apache/hugegraph#3209 and apache/hugegraph-toolchain#771 Review Comment: ⚠️ Important. Blocking: no. Summary: Please scope REST decimal availability to the HugeGraph server release containing #3209, and describe the toolchain version on the client API entry. Evidence: apache/hugegraph#3209 adds the server DataType.DECIMAL and REST support; apache/hugegraph-toolchain#771 adds client Builder.asDecimal(), which REST callers do not need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
