imbajin commented on code in PR #3308:
URL: https://github.com/apache/hugegraph/pull/3308#discussion_r4250985693


##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/DistributedTaskScheduler.java:
##########
@@ -120,7 +125,7 @@ private static boolean sleep(long ms) {
         }
     }
 
-    public void cronSchedule() {
+    public synchronized void cronSchedule() {

Review Comment:
   Removed the method-level cron monitor. Production cron already runs on its 
single scheduler executor; the short schedule/start/physical-owner registration 
gates remain coordinated with close. Close can now set the admission fence 
immediately and reach its existing timed cron barrier even when a cron query is 
blocked.
   
   The new regression submits actual cron work to the same executor and blocks 
its query path. It fails against the previous synchronized method at the 
close-fence assertion. With this correction it verifies admission rejection, a 
real barrier timeout returning false, and successful close after the cron is 
released. Formatting, clean reactor compilation and the final focused 
regressions passed. No new lock, state or executor was introduced.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to