imbajin commented on code in PR #3308:
URL: https://github.com/apache/hugegraph/pull/3308#discussion_r4253762391
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/StandardHugeGraph.java:
##########
@@ -1212,12 +1213,16 @@ public void create(String configPath, GlobalMasterInfo
nodeInfo) {
@Override
public void drop() {
+ this.checkGraphNotClosed();
+ TaskScheduler scheduler = this.taskManager.getScheduler(this.params);
+ if (scheduler != null && !scheduler.close()) {
+ // Fence admission before waiting for actual task owners to exit.
+ this.waitUntilAllTasksCompleted();
Review Comment:
Addressed in [the maintenance-contract
correction](https://github.com/apache/hugegraph/commit/7b0ed580b25be26f522bb4de92ad5cf61581c5f9)
using the explicit retained-fence option in this review. Admission remains
closed after refusal. Both local and PD timeout/second-close refusal messages
now say so, with deletion retry after owners exit or server restart to resume
task admission. The runtime document limits restart recovery to before
destructive cleanup and explains that retaining graph data/configuration does
not restore normal asynchronous task service.
The existing local/PD refusal regressions now assert these messages and
reject a new task, while retaining their data/configuration/metadata checks and
successful deletion retry after the original owner exits. Reopening a flag
would not restore the distributed scheduler's cancelled cron, so no recovery
protocol is added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
