imbajin commented on code in PR #3308:
URL: https://github.com/apache/hugegraph/pull/3308#discussion_r4253762199
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/TaskManager.java:
##########
@@ -261,7 +251,8 @@ public ServerInfoManager
getServerInfoManager(HugeGraphParams graph) {
}
public void shutdown(long timeout) {
- assert this.schedulers.isEmpty() : this.schedulers.size();
+ E.checkState(this.schedulers.isEmpty(),
Review Comment:
Fixed in [the shutdown-grace
correction](https://github.com/apache/hugegraph/commit/7b0ed580b25be26f522bb4de92ad5cf61581c5f9).
The introduced hard precondition is now a warning; the existing executor
shutdown/await sequence is preserved. Retained schedulers are not removed and
global resource shutdown does not acknowledge graph closure.
The new isolated regression fails at the old guard. After the correction, a
real worker completes its final database-executor callback and all shared
executors terminate while the scheduler registration remains. Separate Memory
and RocksDB JVMs also ran an actual persistent task through refused graph close
and HugeFactory.shutdown, then queried its SUCCESS record directly from the
backend; graph data/configuration remained intact. The inherited timeout
short-circuit and other producer shutdown-order issues are recorded separately,
without expanding this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
