imbajin commented on PR #3308: URL: https://github.com/apache/hugegraph/pull/3308#issuecomment-6136236611
Source cross-check of the current [memory CI error](https://github.com/apache/hugegraph/actions/runs/38330840739/job/115080354182): `ConsumersTest.testAwaitThrowsWhenConsumerThrows` calls `provide(1)` before entering the try/catch around `await()`. If the consumer throws immediately after the offer, `provide()` observes `stopped` and rethrows that original exception first. This matches the uncaught worker exception in this run. Both `Consumers.java` and `ConsumersTest.java` are byte-identical in base 68fb045, bb3ebc85, d61a8cd4 and the tested merge. This is a source-supported diagnosis of an existing fixture race, not a reproduced regression introduced by the shutdown correction. A focused fix is to gate the consumer's throw until `provide()` returns, then assert the intended `await()` failure. Please retain the exception assertion rather than weakening it or treating a retry alone as proof. No new test was run for this review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
