pallavithegod commented on code in PR #3362:
URL: https://github.com/apache/hugegraph/pull/3362#discussion_r4306781123
##########
hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/StoreNodeService.java:
##########
@@ -288,6 +292,8 @@ public synchronized Metapb.Store updateStore(Metapb.Store
store) throws PDExcept
}
storeInfoMeta.updateStore(store);
+ // Temporary Offline reports retain the existing keepalive entry
without renewing it.
+ // Removing it here makes a rolling restart fail the
initial-store-count gate.
Review Comment:
Administrative Offline removes the active entry again, including an
already-Offline record with a lingering lease. Separate regressions confirm
that labels-only updates preserve a restoring lease and temporary shutdown
reports do not remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
