pallavithegod commented on code in PR #3362:
URL: https://github.com/apache/hugegraph/pull/3362#discussion_r4316836575
##########
hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/service/PDService.java:
##########
@@ -438,6 +439,24 @@ public void getStore(Pdpb.GetStoreRequest request,
observer.onCompleted();
}
+ @Override
+ public void reportStoreShutdown(Pdpb.SetStoreRequest request,
+ StreamObserver<Pdpb.SetStoreResponse>
observer) {
+ if (!isLeader()) {
+ redirectToLeader(PDGrpc.getReportStoreShutdownMethod(), request,
observer);
+ return;
+ }
+ Pdpb.SetStoreResponse response;
+ try {
+ Metapb.Store store =
storeNodeService.reportStoreShutdown(request.getStore().getId());
Review Comment:
Fixed in ebdc83863: the scoped interceptor requires the configured
privileged internal credential on every shutdown-report call, including
followers; this grants internal privileges across Store IDs. Five real gRPC
cases, deployment rendering and 310 chart tests pass; could you approve
current-head CI and re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
