bitflicker64 commented on PR #3362: URL: https://github.com/apache/hugegraph/pull/3362#issuecomment-6335344042
The earlier review comments below still apply at e7cdb78; this head does not fix them. - Critical: This import, and `PDService` in `StoreShutdownReportTest` (line 39), resolve against the `hg-pd-service` artifact because `hg-pd-test` compiles its tests as main sources. In a reactor `package` build that artifact is the Spring Boot repackaged jar, with the classes under `BOOT-INF/classes/`, so `hg-pd-test` fails with `package org.apache.hugegraph.pd.service.interceptor does not exist` and `cannot find symbol: class PDService`, and the build stops there. (https://github.com/apache/hugegraph/pull/3362#discussion_r4317532374) - Important: A report that reaches a follower is forwarded without its credential, so the leader refuses it and the Store's shutdown report never takes effect in that case. (https://github.com/apache/hugegraph/pull/3362#discussion_r4317532383) - Minor: The chart now owns `HG_PD_AUTH_SECRET_KEY` on the Store container, but the `store` entry of `$reservedEnv` in `_helpers.tpl` (line 948) does not list it, while the `pd` entry does. A `store.extraEnv` entry with that name therefore renders after this one and, as the comment above `$reservedEnv` says, the last duplicate wins, so it silently replaces the chart's Secret reference. A mismatched value only shows up as a warning at shutdown, because the report is refused and the Store falls back to expiry. (https://github.com/apache/hugegraph/pull/3362#discussion_r4317532392) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
