bitflicker64 commented on code in PR #414:
URL: https://github.com/apache/hugegraph-ai/pull/414#discussion_r4580997499


##########
hugegraph-llm/src/hugegraph_llm/indices/vector_index/base.py:
##########
@@ -32,15 +32,31 @@ def add(self, vectors: List[List[float]], props: List[Any]):
         """
         Add a list of vectors and their corresponding properties to the store.
 
+        String properties round-trip verbatim through search() and

Review Comment:
   Important: at this head `MilvusVectorIndex.search` still runs `json.loads` 
on each property, so `"123"` returns as `123`, and `get_all_properties` filters 
`property != ""`, so empty strings vanish; this promise holds only after #412. 
Move the string round-trip sentences into #412 beside the code that implements 
them, or hold this PR until #412 merges.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to