imbajin commented on code in PR #414:
URL: https://github.com/apache/hugegraph-ai/pull/414#discussion_r4532634500


##########
hugegraph-llm/src/hugegraph_llm/indices/vector_index/base.py:
##########
@@ -38,9 +38,12 @@ def add(self, vectors: List[List[float]], props: List[Any]):
         """
 
     @abstractmethod
-    def get_all_properties(self) -> list[str]:
+    def get_all_properties(self) -> list[Any]:
         """
-        #TODO: finish comment
+        Return all properties currently stored in the index.
+
+        Returns:
+            List[Any]: The values previously passed to add().

Review Comment:
   ⚠️ This promises the values passed to `add()`, but `MilvusVectorIndex.add()` 
JSON-encodes non-string values and `get_all_properties()` returns those encoded 
strings while filtering out empty strings. For example, a stored dictionary is 
returned as a JSON string and an empty string is omitted. Please document these 
backend differences or make the implementation return the original values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to