lplalbert commented on code in PR #414:
URL: https://github.com/apache/hugegraph-ai/pull/414#discussion_r4581385217


##########
hugegraph-llm/src/hugegraph_llm/indices/vector_index/base.py:
##########
@@ -32,15 +32,31 @@ def add(self, vectors: List[List[float]], props: List[Any]):
         """
         Add a list of vectors and their corresponding properties to the store.
 
+        String properties round-trip verbatim through search() and

Review Comment:
   Moved — `4c9731d` takes your first option.
   
   Root cause of the overpromise: I documented the string round-trip guarantee 
here while the code that establishes it for Milvus lives in #412 (`129cc48`), 
so this head promised behavior it does not yet implement.
   
   Structural fix: the string round-trip sentences now sit beside that 
implementation — `MilvusVectorIndex.search`/`get_all_properties` in #412 
(`83ba325`) state that property strings round-trip verbatim, including 
JSON-shaped text and empty strings. This PR now documents only what its own 
code establishes: the per-backend non-string storage forms (pickle values / 
JSON payloads / JSON text), the input-API vs read-API split, and the guidance 
to pass strings to avoid those differences.
   
   Validation: docstring-only change — `ruff format --check` / `ruff check` / 
`ty check` clean on `base.py`. No holding on #412 is needed: the two PRs no 
longer claim overlapping behavior, so each head's docs match its own code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to