rdblue commented on a change in pull request #85: Encryption APIs for Iceberg.
URL: https://github.com/apache/incubator-iceberg/pull/85#discussion_r253150915
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/Table.java
 ##########
 @@ -185,4 +186,13 @@ default AppendFiles newFastAppend() {
    */
   FileIO io();
 
+  /**
+   * @return an {@link com.netflix.iceberg.encryption.EncryptionManager} to 
encrypt and decrypt
+   * data files.
+   */
+  default EncryptionManager encryption() {
 
 Review comment:
   I was thinking that this would return null by default to signal that no 
encryption manager should be used. I guess we could also create a 
PlaintextEncryptionManager that doesn't wrap streams.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to