rdblue commented on a change in pull request #85: Encryption APIs for Iceberg.
URL: https://github.com/apache/incubator-iceberg/pull/85#discussion_r253199495
##########
File path: api/src/main/java/com/netflix/iceberg/DataFile.java
##########
@@ -127,6 +129,12 @@ static StructType getType(StructType partitionType) {
*/
Map<Integer, ByteBuffer> upperBounds();
+ /**
+ * @return metadata about how this file is encrypted, or null if the file is
stored in plain
+ * text.
+ */
+ EncryptionKeyMetadata keyMetadata();
Review comment:
Why not pass ByteBuffer to the key manager, too? Since EncryptionKeyMetadata
is just a byte buffer, I don't think it makes much sense to wrap it in an
object. That just makes it harder to read and write. For example: `return
keyMetadata == null ? null : keyMetadata.keyMetadata();`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
