rdblue commented on a change in pull request #85: Encryption APIs for Iceberg.
URL: https://github.com/apache/incubator-iceberg/pull/85#discussion_r255214827
##########
File path: core/src/main/java/com/netflix/iceberg/GenericDataFile.java
##########
@@ -402,6 +421,7 @@ public String toString() {
.add("null_value_counts", nullValueCounts)
.add("lower_bounds", lowerBounds)
.add("upper_bounds", upperBounds)
+ .add("key_metadata", keyMetadata == null ? "null" : "<redacted>")
Review comment:
Nit: if you're committing another version, then please use `(redacted)`
instead because `<` and `>` must be escaped when displayed in web pages. Not a
big deal, I just try to stick with parens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
