rdblue commented on a change in pull request #85: Encryption APIs for Iceberg. URL: https://github.com/apache/incubator-iceberg/pull/85#discussion_r253247147
########## File path: core/src/main/java/com/netflix/iceberg/util/ByteBuffers.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package com.netflix.iceberg.util; + +import java.nio.ByteBuffer; +import java.util.Arrays; + +public class ByteBuffers { + + public static byte[] copy(ByteBuffer buffer) { Review comment: We definitely want to avoid defensive copies. My point here is more about the promise the name "copy" makes. It should not claim to copy and not actually copy (my bad). If we don't need a copy when extracting the value from the ByteBuffer, that would be ideal. For data files in ScanTasks, we should not need to copy because a defensive copy is made in the planning process. That's required because records are reused in deserialization to avoid instantiation and GC overhead. Once past the scan filters, they have to be copied. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
