rdblue commented on a change in pull request #117: Sorts bin packing by weights
in descending order
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r266531360
##########
File path: core/src/test/java/com/netflix/iceberg/util/TestBinPacking.java
##########
@@ -162,14 +162,30 @@ public void testBinPackingLookBack() {
// 6. [5, 1]
Assert.assertEquals("1 bin look-back: should merge ones with fives",
l(l(5, 1), l(5, 1), l(5, 1)), pack(l(5, 1, 5, 1, 5, 1), 8, 1));
+
+ Assert.assertEquals("2 bin look-back: should merge all ones with five when
expensiveTaskFirst is enabled",
+ l(l(5, 1, 1, 1), l(5, 5)), pack(l(5, 1, 5, 1, 5, 1), 10, 2, true));
Review comment:
This doesn't exercise the largest bin first case because it never requires
more than 2 bins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
