rdblue commented on a change in pull request #117: Sorts bin packing by weights in descending order URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r262752027
########## File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java ########## @@ -23,6 +23,8 @@ import com.google.common.collect.ImmutableList; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; + Review comment: Nit: should not add an empty line. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
