rdblue commented on a change in pull request #117: Sorts bin packing by weights
in descending order
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r266530061
##########
File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java
##########
@@ -55,20 +58,22 @@ public ListPacker(long targetWeight, int lookback) {
private final long targetWeight;
private final int lookback;
private final Function<T, Long> weightFunc;
+ private final boolean expensiveTaskFirst;
public PackingIterable(Iterable<T> iterable, long targetWeight, int
lookback,
- Function<T, Long> weightFunc) {
+ Function<T, Long> weightFunc, boolean
expensiveTaskFirst) {
Review comment:
I think this should have a better name. This name assumes that the packing
is done to produce tasks, but this is more generic. What about using
`largestBinFirst`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
