rdblue commented on a change in pull request #117: Sorts bin packing by weights
in descending order
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r266535261
##########
File path: core/src/main/java/com/netflix/iceberg/MergingSnapshotUpdate.java
##########
@@ -436,7 +436,7 @@ private ManifestFile filterManifest(Expression
deleteExpression,
// use a lookback of 1 to avoid reordering the manifests. using 1 also
means this should pack
// from the end so that the manifest that gets under-filled is the first
one, which will be
// merged the next time.
- ListPacker<ManifestFile> packer = new
ListPacker<>(manifestTargetSizeBytes, 1);
+ ListPacker<ManifestFile> packer = new
ListPacker<>(manifestTargetSizeBytes, 1, false);
Review comment:
`false` is the correct setting.
Iceberg tries to avoid reordering manifests so that the manifests and data
files are roughly kept in order of most to least recently modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
