rdblue commented on a change in pull request #117: Sorts bin packing by weights in descending order URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r266536006
########## File path: core/src/main/java/com/netflix/iceberg/TableProperties.java ########## @@ -62,6 +62,9 @@ public static final String SPLIT_LOOKBACK = "read.split.planning-lookback"; public static final int SPLIT_LOOKBACK_DEFAULT = 10; + public static final String SPLIT_EXPENSIVE_TASK_FIRST_ENABLED = "read.split.planning-expensive-task-first.enabled"; Review comment: What is the value of making this a table setting? We think that there are cases where it is valuable. Are there also cases where you would want it turned off? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
