mccheah commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268230832
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -142,10 +142,10 @@ private String escape(String string) {
public String partitionToPath(StructLike data) {
StringBuilder sb = new StringBuilder();
- Class<?>[] javaClasses = javaClasses();
- for (int i = 0; i < javaClasses.length; i += 1) {
+ Class<?>[] initializedClasses = javaClasses();
Review comment:
Yes, because `javaClasses` hides a field in the class. We cannot have
variable names that are the same as names of fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
