mccheah commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268286179
##########
File path: api/src/main/java/org/apache/iceberg/FileFormat.java
##########
@@ -71,9 +71,9 @@ public static FileFormat fromFileName(CharSequence filename)
{
return null;
}
- private static int lastIndexOf(char c, CharSequence seq) {
+ private static int lastIndexOf(char ch, CharSequence seq) {
Review comment:
Hm, so when I was editing the code to match the style guidelines, I found
`W` and `L` to themselves be opaque, and I had to give a moment's thought to
consider how to rename them since I had to derive what the semantic meaning
was. Now, one can of course know what these variables mean in the context of
the code they're in - it didn't take me long to understand what they were for.
But I'd like for us to reconsider modifying the spec to make those variables
fully descriptive of what they represent, so that they can be understood at a
glance of either the spec or the code. Code should be self documenting as much
as possible. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
