mccheah commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268238592
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -313,8 +312,8 @@ private void checkAndAddPartitionName(String name) {
partitionNames.add(name);
}
- public Builder withSpecId(int specId) {
- this.specId = specId;
+ public Builder withSpecId(int newSpecId) {
Review comment:
Again we run into the same problem of the majority of cases being better to
follow the standard - generally naming vars and parameters the same as fields
is dubious. I think it's ok that in some cases where it might be considered
acceptable to break this trend, to nevertheless conform to the global standard.
Otherwise, we'd have to add a `SuppressWarnings` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
