mccheah commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268292052
##########
File path: api/src/main/java/org/apache/iceberg/PartitionField.java
##########
@@ -68,11 +68,9 @@ public boolean equals(Object other) {
}
PartitionField that = (PartitionField) other;
- return (
- sourceId == that.sourceId &&
+ return sourceId == that.sourceId &&
Review comment:
I don't think the parens added readability - quite the opposite in fact,
given that whenever I see parentheses I assume there would be some other clause
in the boolean clause, e.g. `(...) && (...)`. It's a built-in rule in
Checkstyle:
http://checkstyle.sourceforge.net/config_coding.html#UnnecessaryParentheses.
Doesn't look like it's strictly annotated in the style guide though:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
