mccheah commented on a change in pull request #153: [Baseline] Apply baseline linting to iceberg-core URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r274058052
########## File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java ########## @@ -42,8 +42,8 @@ // lazily initialized private List<ManifestFile> manifests = null; - private List<DataFile> adds = null; - private List<DataFile> deletes = null; + private List<DataFile> cachedAdds = null; Review comment: There's local vars in `cacheChanges` below that use the names `adds` and `deletes` that can't hide these fields. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
