mccheah commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r274058919
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -171,7 +168,7 @@ public InclusiveManifestEvaluator load(Integer specId) {
new ScanEvent(table.toString(), snapshot.snapshotId(), rowFilter,
schema()));
Iterable<ManifestFile> matchingManifests =
Iterables.filter(snapshot.manifests(),
- manifest ->
evalCache.getUnchecked(manifest.partitionSpecId()).eval(manifest));
+ manifest ->
evalCache.get(manifest.partitionSpecId()).eval(manifest));
Review comment:
Baseline has opinions about using Caffeine caches vs. Guava caches. There
are many reasons to prefer Caffeine caches over Guava caches, largely around
performance. The APIs are only marginally different - we see an example of an
API difference here, where `cache.get` won't throw a checked
`ExecutionException`; that API doesn't declare any checked exceptions being
thrown at all.
We discuss some of the implications of Caffeine vs. Guava here:
https://github.com/palantir/gradle-baseline/pull/317.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
