mccheah commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r276762861
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -171,7 +168,7 @@ public InclusiveManifestEvaluator load(Integer specId) {
new ScanEvent(table.toString(), snapshot.snapshotId(), rowFilter,
schema()));
Iterable<ManifestFile> matchingManifests =
Iterables.filter(snapshot.manifests(),
- manifest ->
evalCache.getUnchecked(manifest.partitionSpecId()).eval(manifest));
+ manifest ->
evalCache.get(manifest.partitionSpecId()).eval(manifest));
Review comment:
Taking a look at Caffeine's pom it doesn't look like they pull in any
dependencies apart from annotations:
http://central.maven.org/maven2/com/github/ben-manes/caffeine/caffeine/2.7.0/caffeine-2.7.0.pom
We can ask the authors about the API stability, but I can't imagine the APIs
changing within a major version.
I'm not keen on changing the Baseline rules if we don't have to and if the
way forward is relatively straightforward. If Baseline is encouraging us to do
the right thing, we should do the right thing instead of compromising.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
