mccheah commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r276046439
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotUpdate.java
##########
@@ -243,19 +238,21 @@ protected void add(DataFile file) {
group.add(manifest);
groups.put(manifest.partitionSpecId(), group);
}
- }
+ });
}
List<ManifestFile> manifests = Lists.newArrayList();
- for (Map.Entry<Integer, List<ManifestFile>> entry : groups.entrySet()) {
- for (ManifestFile manifest : mergeGroup(entry.getKey(),
entry.getValue())) {
- manifests.add(manifest);
+ groups.forEach((groupId, manifestGroup) -> {
Review comment:
Let's resolve the discussion in
https://github.com/apache/incubator-iceberg/pull/153#discussion_r274062236 and
then apply whatever conclusion we draw everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
