rdblue commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r281856193
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotUpdate.java
##########
@@ -266,6 +235,42 @@ protected void add(DataFile file) {
}
}
+ private void groupManifestsByPartitionSpec(
+ Snapshot current,
+ Map<Integer, List<ManifestFile>> groups,
+ StrictMetricsEvaluator metricsEvaluator, Set<CharSequenceWrapper>
deletedFiles) throws IOException {
Review comment:
I think this should be divided into 2 methods:
* `filterManifests` that runs all the filters, and
* `groupManifestsByPartitionSpec` that does the grouping
The current name doesn't indicate that filtering is also done and mixes the
two concerns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
