rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r300060612
##########
File path: orc/src/main/java/org/apache/iceberg/orc/TypeConversion.java
##########
@@ -35,19 +41,21 @@
* @return the ORC schema
*/
public static TypeDescription toOrc(Schema schema,
- ColumnIdMap columnIds) {
- return toOrc(null, schema.asStruct(), columnIds);
+ Map<TypeDescription, IcebergColumn>
columnIds) {
Review comment:
I don't like to modify function parameters. Can you either return both from
the method (use `Pair` if you need) or separate the mapping and the conversion
to separate methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
