rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r300060980
##########
File path: orc/src/main/java/org/apache/iceberg/orc/TypeConversion.java
##########
@@ -122,11 +124,13 @@ static TypeDescription toOrc(Integer fieldId,
* @param columnIds the column ids
* @return the Iceberg schema
*/
- public Schema fromOrc(TypeDescription schema, ColumnIdMap columnIds) {
+ public static Schema fromOrc(TypeDescription schema,
+ Map<TypeDescription, IcebergColumn> columnIds) {
return new Schema(convertOrcToType(schema,
columnIds).asStructType().fields());
}
- Type convertOrcToType(TypeDescription schema, ColumnIdMap columnIds) {
+ private static Type convertOrcToType(TypeDescription schema,
+ Map<TypeDescription, IcebergColumn>
columnIds) {
Review comment:
Maybe rename to `mapping` now that this is not just column IDs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
