rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r300067717
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java
##########
@@ -59,10 +60,22 @@
@SuppressWarnings("unchecked")
@Override
public Iterator<T> iterator() {
+ final Reader orcFileReader = newFileReader(file, config);
+ // TODO: address schema evolution case
+ final Map<TypeDescription, IcebergColumn> colMapping = orcFileReader
Review comment:
No need for `final`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
