rdblue commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r300062920
########## File path: site/docs/spec.md ########## @@ -473,7 +473,7 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo One of the interesting challenges with this is how to map Iceberg’s schema evolution (id based) on to ORC’s (name based). In theory we could use Iceberg’s column ids as the column and field names, but that would suck from a user’s point of view. -The column ids would be stored in ORC’s user metadata as “iceberg.column.id” with a comma separated list of the ids. +The column ids would be stored in ORC’s user metadata as key `iceberg.column.mapping` with a comma separated list of the ids with format `orc_id:iceberg_id:(required|optional),orc_id:iceberg_id:(required|optional),...` per column mapping. Review comment: This should be updated to use stronger language "Iceberg column IDs must be stored in ORC user metadata using the key `iceberg.column.mapping` ..." ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
