rdblue commented on a change in pull request #351: Extend Iceberg with a way to
overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r313643617
##########
File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java
##########
@@ -65,6 +70,17 @@
*/
OverwriteFiles addFile(DataFile file);
+ /**
+ * Delete a {@link DataFile} from the table.
+ * <p>
+ * Note that either this method or {@link
OverwriteFiles#overwriteByRowFilter(Expression)}
+ * should be used to mark deleted files, not both.
Review comment:
Like my comment above, I don't think this paragraph is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
