rdblue commented on a change in pull request #351: Extend Iceberg with a way to
overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r313646840
##########
File path: core/src/main/java/org/apache/iceberg/OverwriteData.java
##########
@@ -88,6 +121,40 @@ public OverwriteFiles validateAddedFiles() {
}
}
+ if (conflictingAppendsRowFilter != null) {
+ PartitionSpec spec = writeSpec();
+ Expression inclusiveExpr =
Projections.inclusive(spec).project(conflictingAppendsRowFilter);
+ Evaluator inclusive = new Evaluator(spec.partitionType(), inclusiveExpr);
+
+ List<DataFile> newFiles = collectNewFiles(base);
+ for (DataFile newFile : newFiles) {
+ // we do partition-level conflict resolution right now
+ // we can enhance it by leveraging column stats and MetricsEvaluator
Review comment:
Is there a reason not to add these optimizations now? If you don't want to
add these, then let's at least add a follow-up issue for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
