rdblue commented on a change in pull request #351: Extend Iceberg with a way to
overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r313644692
##########
File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java
##########
@@ -24,18 +24,17 @@
import org.apache.iceberg.expressions.Projections;
/**
- * API for overwriting files in a table by filter expression.
+ * API for overwriting files in a table.
* <p>
* This API accumulates file additions and produces a new {@link Snapshot} of
the table by replacing
- * all the files that match the filter expression with the set of additions.
This operation is used
- * to implement idempotent writes that always replace a section of a table
with new data.
+ * all the deleted files with the set of additions. This operation is used to
implement idempotent
+ * writes that always replace a section of a table with new data or
update/delete operations that
+ * eagerly overwrite files.
Review comment:
I think this should note that the default validation mode is idempotent --
that is, the overwrite is correct and should be committed out regardless of
other concurrent changes to the table.
It may also help to add examples. The normal idempotent write is "replace
all the data for day D with query results", and the normal eager overwrite case
is "replace these files with filtered versions and ensure no new data that
would need to be filtered has been added".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
